Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix w3c warnings #3572

Merged
merged 1 commit into from
Feb 21, 2018
Merged

fix w3c warnings #3572

merged 1 commit into from
Feb 21, 2018

Conversation

oliviertassinari
Copy link
Contributor

@oliviertassinari oliviertassinari commented Jan 14, 2018

Up until HTML5 type was needed for the browser to distinguish between js and other text. With HTML5 it is no longer needed. What browsers do you support?

The issue was raised in mui/material-ui#9867. You can reproduce it with the https://zeit.co/now website:
capture d ecran 2018-01-14 a 16 46 19

I'm assuming it's safe to remove it.

@oliviertassinari
Copy link
Contributor Author

@timneutkens Updated

Copy link
Contributor

@arunoda arunoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@arunoda arunoda merged commit 832425e into vercel:canary Feb 21, 2018
@oliviertassinari
Copy link
Contributor Author

👯‍♂️

@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants