[docs][Joy] component, slots, slotProps must be visible in Prop table in API docs
#36666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hbjORbj
commented
Mar 28, 2023
•
hbjORbj
commented
- I have followed (at least) the PR section of the contributing guide.
hbjORbj
added
docs
Netlify deploy previewhttps://deploy-preview-36666--material-ui.netlify.app/ @mui/joy: parsed: +1.29% , gzip: +1.06% Bundle size report |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
hbjORbj
force-pushed
the
joy/proptypes
branch
2 times, most recently
from
158c924
to
bf81ce3
Compare
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
hbjORbj
force-pushed
the
joy/proptypes
branch
3 times, most recently
from
13fb1e4
to
a7216f4
Compare
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
Both #36599 and #36540 are merged. This is ready for review. @siriwatknp |
siriwatknp
reviewed
Apr 11, 2023
Comment on lines
+127
to
+129
| component, | ||
| slots = {}, | ||
| slotProps = {}, |
There was a problem hiding this comment.
@hbjORbj What's the reason to explicitly declare these props and compose them again in the externalForwardedProps?
My intention is that the useSlot will take care of them internally so we don't have to do this in all components.
There was a problem hiding this comment.
If we don't do this, then they don't show up in Proptypes (and hence not in JSON files), and hence they don't appear in Prop table in API docs
siriwatknp
approved these changes
Apr 13, 2023
|
@siriwatknp I've already handled that in this PR and merged it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.