[base] Do not merge internal ownerState with ownerState from props
#36599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbjORbj
changed the title
ownerState with ownerState from props
hbjORbj
added
package: base-ui
Netlify deploy previewhttps://deploy-preview-36599--material-ui.netlify.app/ @mui/joy: parsed: +0.04% , gzip: +0.13% Bundle size report |
hbjORbj
force-pushed
the
base/ownerstate
branch
from
5619658
to
6c3da4c
Compare
hbjORbj
force-pushed
the
base/ownerstate
branch
from
6449324
to
f71dc53
Compare
Merged
1 task
michaldudak
requested changes
Mar 31, 2023
siriwatknp
reviewed
Apr 4, 2023
siriwatknp
reviewed
Apr 4, 2023
packages/mui-joy/src/Menu/Menu.tsx
Outdated
Comment on lines
149
to
151
| slots: { | ||
| root: component || 'ul', | ||
| }, |
There was a problem hiding this comment.
Can you add a test to ensure that the Menu produces ul?
siriwatknp
reviewed
Apr 5, 2023
Comment on lines
55
to
76
| slots: { | ||
| root: { | ||
| expectedClassName: classes.root, | ||
| }, | ||
| input: { | ||
| testWithComponent: React.forwardRef<HTMLInputElement>((props, ref) => ( | ||
| <input ref={ref} {...props} data-testid="custom" /> | ||
| )), | ||
| testWithElement: 'input', | ||
| expectedClassName: classes.input, | ||
| }, | ||
| listbox: { | ||
| testWithComponent: React.forwardRef<HTMLDivElement>((props, ref) => ( | ||
| <div ref={ref} {...props} data-testid="custom" /> | ||
| )), | ||
| testWithElement: 'div', | ||
| expectedClassName: classes.listbox, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
@hbjORbj please add slot tests for other Joy components.
There was a problem hiding this comment.
Gottcha (doing in a separate PR).
|
I just fixed the last error. I think we can merge this. @siriwatknp |
1 task
1 task
siriwatknp
reviewed
Apr 10, 2023
| @@ -11,6 +11,7 @@ | |||
| "onClose": "Triggered when focus leaves the menu and the menu should close.", | |||
| "open": "Controls whether the menu is displayed.", | |||
| "size": "The size of the component (affect other nested list* components because the <code>Menu</code> inherits <code>List</code>). To learn how to add custom sizes to the component, check out <a href=\"/joy-ui/customization/themed-components/#extend-sizes\">Themed components—Extend sizes</a>.", | |||
| "slots": "The components used for each slot inside the Popper. Either a string to use a HTML element or a component. See <a href=\"#slots\">Slots API</a> below for more details.", | |||
There was a problem hiding this comment.
@hbjORbj Would this be fixed in this PR or the next one?
Screen.Recording.2566-04-10.at.09.50.07.mov
hbjORbj
changed the title
ownerState with ownerState from propsownerState with ownerState from props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36597
This PR handles Task 1 in MUI Core Roadmap and Task 2 in MUI Core Roadmap
Affected components: Joy
Menu, JoyAutocomplete, JoySelect, JoyTooltip,MenuUnstyled,SelectUnstyledBefore
After