Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Add tests for slots/slotProps for all components #36828

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Apr 9, 2023

⚠️ This PR must be merged after ##36599 and #36540 are merged.

@hbjORbj hbjORbj self-assigned this Apr 9, 2023
@hbjORbj hbjORbj marked this pull request as draft April 9, 2023 20:03
@hbjORbj hbjORbj added test package: joy-ui Specific to @mui/joy labels Apr 9, 2023
@mui-bot
Copy link

mui-bot commented Apr 9, 2023

Netlify deploy preview

https://deploy-preview-36828--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 64634ca

@hbjORbj hbjORbj force-pushed the add/slots-tests branch 3 times, most recently from 1e98799 to 8fcafb6 Compare April 9, 2023 22:21
@hbjORbj
Copy link
Member Author

hbjORbj commented Apr 9, 2023

@hbjORbj hbjORbj requested a review from siriwatknp April 9, 2023 22:24
@hbjORbj hbjORbj marked this pull request as ready for review April 9, 2023 22:24
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 10, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 10, 2023
@hbjORbj
Copy link
Member Author

hbjORbj commented Apr 10, 2023

Both #36599 and #36540 are merged. This is ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: joy-ui Specific to @mui/joy test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants