Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RFC template #729

Merged
merged 6 commits into from
Aug 9, 2022
Merged

Add RFC template #729

merged 6 commits into from
Aug 9, 2022

Conversation

bytasv
Copy link
Contributor

@bytasv bytasv commented Aug 3, 2022

A template for RFCs

@bytasv bytasv added the RFC Request For Comments label Aug 3, 2022
@bytasv bytasv self-assigned this Aug 3, 2022
@render
Copy link

render bot commented Aug 3, 2022

Your Render PR Server URL is https://toolpad-pr-729.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cbl8ghk41ls5copf8qtg.

@oliviertassinari oliviertassinari requested a deployment to rfc-issue-template - toolpad-db PR #729 August 3, 2022 14:38 — with Render Abandoned
@mnajdova
Copy link
Member

mnajdova commented Aug 8, 2022

Maybe we also need a section for examples? This is the easiest way for seeing new API in action.

@bytasv
Copy link
Contributor Author

bytasv commented Aug 8, 2022

Maybe we also need a section for examples? This is the easiest way for seeing new API in action.

@mnajdova in the Proposed option section we have this line:

  • including code examples if you're proposing an interface or system contract

Do you think we should add Examples as a standalone section? I'm thinking that if I were to open an RFC I would aim to add examples in Proposed option and What are our options? sections anyways 🤔
Maybe it would be enough to extend What are our options? section and also mentioned that examples could be useful?

@bytasv @mnajdova
Update .github/ISSUE_TEMPLATE/3.rfc.yml
ef6957d 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Signed-off-by: Vytautas Butkus <vytautas.butkus@gmail.com>
@render
Copy link

render bot commented Aug 8, 2022

Your Render PR Server URL is https://toolpad-pr-729.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cbohft1a6gdvvu1l1i5g.

@oliviertassinari oliviertassinari requested a deployment to rfc-issue-template - toolpad-db PR #729 August 8, 2022 14:04 — with Render Abandoned
@mnajdova mnajdova added the core Infrastructure work going on behind the scenes label Aug 8, 2022
bytasv and others added 3 commits August 8, 2022 17:15
@bytasv @mnajdova
Update .github/ISSUE_TEMPLATE/3.rfc.yml
0a028c3 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Signed-off-by: Vytautas Butkus <vytautas.butkus@gmail.com>
@bytasv
Add areas to consider for what are our options section
4e666bd
@bytasv
Tweak proposed solution helper text
7013714
mnajdova
mnajdova approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my end :)

DanailH
DanailH approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@DanailH DanailH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I think it's solid. Should you convert it from a Draft to a PR?

@bytasv bytasv marked this pull request as ready for review August 9, 2022 10:26
@bytasv bytasv merged commit 4c73e23 into master Aug 9, 2022
@bytasv bytasv deleted the rfc-issue-template branch August 9, 2022 11:06
@oliviertassinari oliviertassinari mentioned this pull request Aug 24, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@DanailH DanailH DanailH approved these changes

Assignees

@bytasv bytasv

Labels
core Infrastructure work going on behind the scenes RFC Request For Comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bytasv @mnajdova @DanailH @oliviertassinari