Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datagrid] Performance tests posted by mui-bot are inaccurate #10381

Closed
romgrk opened this issue Sep 18, 2023 · 2 comments · Fixed by #10414
Closed

[datagrid] Performance tests posted by mui-bot are inaccurate #10381

romgrk opened this issue Sep 18, 2023 · 2 comments · Fixed by #10414
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes

Comments

@romgrk
Copy link
Contributor

romgrk commented Sep 18, 2023

What's the problem? 🤔

The datagrid performance tests run by the datagrid are quite inaccurate. For filtering, they often even show test runs with negative runtime, and I know I optimized filtering a lot but I probably did not make it fast enough to reverse the flow of time.

So I was wondering if we should either remove the tests, or spend time to make them accurate? It would also be way nicer if they'd show the before/after time, rather than just a flat value for the current branch.

In their current state, I'd remove the tests because they're noise that I never look at due to their inaccuracy and that they don't provide a comparison.

cc @mui/xgrid

image

@romgrk romgrk added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! labels Sep 18, 2023
@flaviendelangle
Copy link
Member

Unfortunately I feel like those tests started with a good intention but were never actually used.
Did anyone compared the results between a PR and master for example?

If we have a better idea on how to benchmark performances, it would be great.
But I agree that the current implementation brings no value.

@romgrk
Copy link
Contributor Author

romgrk commented Sep 20, 2023

Even when I worked on filtering, sorting & grouping performance I didn't rely on those numbers. The big issue is the connection via puppeteer, which is naturally async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants