Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Customization playground - fix default theme values #10562

Open
1 task done
oliviertassinari opened this issue Oct 3, 2023 · 2 comments
Open
1 task done

[docs] Customization playground - fix default theme values #10562

oliviertassinari opened this issue Oct 3, 2023 · 2 comments
Assignees
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! customization: css Design CSS customizability docs Improvements or additions to the documentation

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 3, 2023

Steps to reproduce

Link to live example: (required)

Steps:

Screenshot 2023-10-03 at 14 28 30

Current behavior

MUI inc. theme

Expected behavior

Default Material UI theme

Context

#9581

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: qkzjdssef

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer docs Improvements or additions to the documentation labels Oct 3, 2023
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 3, 2023

More reviews on this:

  • 2. I think the desktop should be the first option selected. I wouldn't expect more than 10% of the use to be about the static variant
Screenshot 2023-10-03 at 14 29 13
  • 3. The panel feels off for me, maybe it's about the elevation, the background color, or the rounding.
Screenshot 2023-10-03 at 14 29 59
  • 4. The code style is wrong, sometimes it's missing a closing brackets, sometimes a semicolon, sometimes it's the indentation
Screenshot 2023-10-03 at 14 31 46 Screenshot 2023-10-03 at 14 31 50

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Oct 3, 2023
@alexfauquette alexfauquette added component: pickers This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 3, 2023
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 15, 2024

We discovered more opportunities with @noraleonte today:

SCR-20240816-bhaf

The border definition is set twice, it's redundant:

    borderRadius: '2px',
    borderWidth: '1px',
    borderColor: '#2196f3',
    border: '1px solid',

would be simpler like this:

    border: '1px solid #2196f3',
  • 6. Having an inspector like in the Chrome DevTools to select the element we want to customize:
SCR-20240816-bhms

could improve x2-5 the experience with the tool.

  • 7. I'm confused about the code formating:
SCR-20240816-bjcj

Shouldn't we be explicit about the nested selector behavior '&. ' as in the rest of the codebase. Also use the closing ; and , as in the rest of the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! customization: css Design CSS customizability docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

3 participants