Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fields] Looks like a typo in doesSectionFormatHaveLeadingZeros #10712

Closed
VirtuaBoza opened this issue Oct 18, 2023 · 1 comment · Fixed by #10713
Closed

[fields] Looks like a typo in doesSectionFormatHaveLeadingZeros #10712

VirtuaBoza opened this issue Oct 18, 2023 · 1 comment · Fixed by #10713
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! feature: Keyboard editing Related to the pickers keyboard edition

Comments

@VirtuaBoza
Copy link

VirtuaBoza commented Oct 18, 2023 •
edited
Loading

https://github.com/mui/mui-x/blob/11699655de983a87c1bc063ed167598e697a367a/packages/x-date-pickers/src/internals/hooks/useField/useField.utils.ts#L476C45-L476C45

I found what looks like a typo in useField.utils.ts. In the "seconds" case of doesSectionFormatHaveLeadingZeros, setMinutes is called whereas I expected to see a call to setSeconds.

Search keywords:
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 18, 2023
@flaviendelangle flaviendelangle changed the title Looks like a typo in doesSectionFormatHaveLeadingZeros [fields] Looks like a typo in doesSectionFormatHaveLeadingZeros Oct 18, 2023
@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 18, 2023
@flaviendelangle
Copy link
Member

Thanks for your contribution!

@flaviendelangle flaviendelangle mentioned this issue Oct 18, 2023
Merged
@LukasTy LukasTy added the feature: Keyboard editing Related to the pickers keyboard edition label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! feature: Keyboard editing Related to the pickers keyboard edition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fields] Correctly respect leading zeroes on seconds section flaviendelangle/mui-x
3 participants
@flaviendelangle @LukasTy @VirtuaBoza