Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Popper position is not centered #10852

Closed
lokomass opened this issue Oct 31, 2023 · 5 comments
Closed

[pickers] Popper position is not centered #10852

lokomass opened this issue Oct 31, 2023 · 5 comments
Labels
component: DateRangePicker The React component. component: pickers This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists

Comments

@lokomass
Copy link

lokomass commented Oct 31, 2023

Steps to reproduce

Here is a sandbox, with default component : https://codesandbox.io/s/inspiring-lucy-9m5997

Current behavior

With latest version, popper position is not centered :

image

Expected behavior

If you change versions of picker for 6.10.0 for example, position is good

image

Context

I want a centered popper

Your environment

react 17.2.0

Search keywords: date-range-picker popper

@lokomass lokomass added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 31, 2023
@LukasTy
Copy link
Member

LukasTy commented Oct 31, 2023

Hello @lokomass
We have quite recently fixed this inconsistency for the range picker to be aligned to the start of the anchor (input) as the regular pickers.
There currently is no clean way to change this behavior.
But we have already explored possible temporary workarounds in #10824.
Here is an adaptation of the solutions mentioned in the linked issue to achieve the previous behavior of centering the popper.

I'm closing this issue as a duplicate.
Feel free to follow #10824 to get notified about its progress. 😉

@LukasTy LukasTy closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
@LukasTy LukasTy added duplicate This issue or pull request already exists component: pickers This is the name of the generic UI component, not the React module! component: DateRangePicker The React component. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 31, 2023
@LukasTy LukasTy changed the title Popper position is not centered [pickers] Popper position is not centered Oct 31, 2023
@lokomass
Copy link
Author

lokomass commented Oct 31, 2023

Hello thanks for reply
In your example, popper is not centered

image

@LukasTy
Copy link
Member

LukasTy commented Oct 31, 2023

Hello thanks for reply In your example, popper is not centered

Sorry, I have initially simplified the example too much.
I've updated it to work correctly on the initial render as well. 😉

@lokomass
Copy link
Author

lokomass commented Nov 1, 2023

Thanks for reply, do you know when fix will be release please ?
Thanks again

@LukasTy
Copy link
Member

LukasTy commented Nov 1, 2023

do you know when fix will be release please ?

We have not prioritized the issue yet. I wouldn't wait for it to be released this year.
It does not seem like a critical issue that needs immediate attention, given that there is a workaround for it. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DateRangePicker The React component. component: pickers This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants