Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] header focus outline has visual glitches #11225

Closed
Janpot opened this issue Nov 28, 2023 · 4 comments · Fixed by #13943
Closed

[DataGrid] header focus outline has visual glitches #11225

Janpot opened this issue Nov 28, 2023 · 4 comments · Fixed by #13943
Assignees
Labels
component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@Janpot
Copy link
Member

Janpot commented Nov 28, 2023

Steps to reproduce

Link to live example: https://stackblitz.com/edit/react-xtuj1s?file=Demo.tsx

Current behavior

1. Outline doesn't follow corner radius

Screenshot 2023-11-28 at 15 23 27

2. outline doesn't quite seem to make it past the scrollbar

Screenshot 2023-11-28 at 15 23 07

3. in both screenshots, the bottom border of the outline is missing as well.

Expected behavior

The outline follows the corner radius on both ends. the outline is closed at the bottom

Search keywords: datagrid header focus

@Janpot Janpot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 28, 2023
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Nov 28, 2023
@DanailH DanailH added design This is about UI or UX design, please involve a designer and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 30, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Nov 30, 2023
@MartinTiangco
Copy link

In both screenshots, the outlines on the bottom side of the header cell are not visible. I would expect them to be.

@romgrk
Copy link
Contributor

romgrk commented Jul 2, 2024

The top left border is an issue, but I'm not convinced the right-most cell border is.

If you go up and down the right-most column, the cell border extent stays constant; if we'd extend it to where the scrollbar space is, the border's dimension would jump up/down when going on the header. Making the right-most header cell larger would also bring complexity, because the width increase would necessarily need to be through padding (so the border extends), and we'd need to add a CSS rule specific for that cell, and if users try to add padding on their own they could mess up our padding.

@Janpot
Copy link
Member Author

Janpot commented Jul 3, 2024

I've also added the missing bottom border to the issue, but I admit it's also debatable whether it's a problem or not.

@romgrk romgrk added the good first issue Great for first contributions. Enable to learn the contribution process. label Jul 3, 2024
@romgrk romgrk moved this from 🆕 Needs refinement to 🔖 Ready in MUI X Data Grid Jul 4, 2024
@romgrk romgrk self-assigned this Jul 25, 2024
Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@Janpot: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@DanailH DanailH moved this from 🔖 Ready to ✅ Done in MUI X Data Grid Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer good first issue Great for first contributions. Enable to learn the contribution process.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants