Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] What if my license key gets exposed to public ? #12308

Closed
Ankur-Marwaha opened this issue Mar 3, 2024 · 5 comments
Closed

[data grid] What if my license key gets exposed to public ? #12308

Ankur-Marwaha opened this issue Mar 3, 2024 · 5 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! package: x-license Specific to @mui/x-license. status: waiting for author Issue with insufficient information support: commercial Support request from paid users support: question Community support but can be turned into an improvement

Comments

@Ankur-Marwaha
Copy link

Ankur-Marwaha commented Mar 3, 2024

The problem in depth

The way you suggest to install the key here :
https://mui.com/x/introduction/licensing/#license-key-installation

Will expose the key to public(any user using my site) ?

How do you suggest to make the key secure... ?

Search keywords: security, key stolen
Order ID: 85146

@Ankur-Marwaha Ankur-Marwaha added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: commercial Support request from paid users labels Mar 3, 2024
@michelengelen
Copy link
Member

Hey @Ankur-Marwaha we typically recommend to just hard code the license key into git, but if you need to make this secure you can just use secrets.

We do state that in this section of the docs as well.

Let us know if you have any additional questions.

@michelengelen michelengelen added support: question Community support but can be turned into an improvement component: data grid This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information package: x-license Specific to @mui/x-license. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 4, 2024
@michelengelen michelengelen changed the title What if my license key gets exposed to public ? [data grid] What if my license key gets exposed to public ? Mar 4, 2024
@Ankur-Marwaha
Copy link
Author

Ankur-Marwaha commented Mar 4, 2024

First of all, I am not using Next. but pure client side with React.

Secondly, by hard coding into git (Did you mean adding it through any component(client side js file) inside the src folder?)

Thirdly, I still did not understand if someone gets hold of the key. (which is very easy on the client side).
Will they be able to use it, just like me... ?

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Mar 4, 2024
@michelengelen
Copy link
Member

I guess when you minimize your code it will be kind of hidden, but thats as far as "securing" the license goes on a simple react project.

Our license system is built to be open, since we do not perform any network requests to check them. In order to accomplish this we need an open model for it.

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 5, 2024
@michelengelen
Copy link
Member

If you have any additional questions please feel free to reach out again or, if related, reopen this issue! Thanks! 🙇🏼

Copy link

github-actions bot commented Mar 8, 2024

⚠️ This issue has been closed.
If you have a similar problem, please open a new issue and provide details about your specific problem.
If you can provide additional information related to this topic that could help future readers, please feel free to leave a comment.

How did we do @Ankur-Marwaha?
Your experience with our support team matters to us. If you have a moment, please share your thoughts through our brief survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! package: x-license Specific to @mui/x-license. status: waiting for author Issue with insufficient information support: commercial Support request from paid users support: question Community support but can be turned into an improvement
Projects
None yet
Development

No branches or pull requests

2 participants