Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] multiple docs demos not working - js importing dataset only in ts, not js #13773

Closed
tonyhallett opened this issue Jul 9, 2024 · 2 comments
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation regression A bug, but worse

Comments

@tonyhallett
Copy link
Contributor

tonyhallett commented Jul 9, 2024

Steps to reproduce

Link to live example: (required)

Steps:

  1. Click expand code - "Using a dataset" !
image

( Similar issues with StackBlitz / CodeSandbox )

Current behavior

Error

Expected behavior

No error

Context

This commit refactored, but no js file.

Affected demos
https://github.com/mui/mui-x/blob/22f8f84e0b83a0e14e495fa5b3683c2250bb80c7/docs/data/charts/axis/axis.md
{{"demo": "AxisTextCustomizationNoSnap.js", "hideToolbar": true, "bg": "playground"}} ( ok as hideToolbar )
{{"demo": "GridDemo.js"}}

https://github.com/mui/mui-x/blob/22f8f84e0b83a0e14e495fa5b3683c2250bb80c7/docs/data/charts/bars/bars.md
{{"demo": "BarsDataset.js"}}
{{"demo": "HorizontalBars.js"}}
{{"demo": "TickPlacementBars.js"}}
{{"demo": "GridDemo.js"}}

Your environment

System:
OS: Windows 11 10.0.22631
Binaries:
Node: 22.2.0 - C:\Program Files\nodejs\node.EXE
npm: 10.8.1 - C:\Program Files\nodejs\npm.CMD
pnpm: Not Found
Browsers:
Chrome: Not Found
Edge: Chromium (126.0.2592.87)
npmPackages:
@emotion/react: ^11.11.4 => 11.11.4
@emotion/styled: ^11.11.5 => 11.11.5
@mui/base: 5.0.0-beta.40
@mui/core-downloads-tracker: 5.15.21
@mui/icons-material: ^5.15.20 => 5.15.20
@mui/material: ^5.15.20 => 5.15.21
@mui/private-theming: 5.15.20
@mui/styled-engine: 5.15.14
@mui/system: 5.15.20
@mui/types: 7.2.14
@mui/utils: 5.15.20
@mui/x-charts: ^7.7.1 => 7.7.1
@mui/x-data-grid: ^7.7.1 => 7.7.1
@types/react: ^18.3.3 => 18.3.3
react: ^18.3.1 => 18.3.1
react-dom: ^18.3.1 => 18.3.1
typescript: ^5.4.5 => 5.4.5

Search keywords: weather

@tonyhallett tonyhallett added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 9, 2024
@zannager zannager added the component: charts This is the name of the generic UI component, not the React module! label Jul 9, 2024
@LukasTy
Copy link
Member

LukasTy commented Jul 9, 2024

Thank you for reporting this issue. 🙏
It is no longer a problem on the latest master build (example) and the fixed docs will be released this Thursday/Friday.
There is a related issue that is also being worked on already: mui/material-ui#42733.
I'm closing this issue as already resolved.
If you think that there are still problems here, please feel free to reopen it. 😉

@LukasTy LukasTy closed this as completed Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@tonyhallett: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@LukasTy LukasTy added docs Improvements or additions to the documentation regression A bug, but worse and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 9, 2024
@michelengelen michelengelen changed the title multiple docs demos not working - js importing dataset only in ts, not js [charts] multiple docs demos not working - js importing dataset only in ts, not js Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation regression A bug, but worse
Projects
None yet
Development

No branches or pull requests

3 participants