Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] While dragging outside of the clockface the selection won't trigger #14189

Closed
svidskiy opened this issue Aug 13, 2024 · 3 comments
Closed
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/

Comments

@svidskiy
Copy link

svidskiy commented Aug 13, 2024

Steps to reproduce

Link to live example: (required)

Example

Current behavior

The problem is as follows: if the mouse goes beyond the clock boundaries when selecting the time, the transition or closeOnSelect will not work, but in fact the value changes

IMG_3984.MOV

Expected behavior

Regardless of where the mouse is located, the trigger should work if we have chosen a value of

Context

No response

Your environment

npx @mui/envinfo
  System:
    OS: Windows 11 10.0.22631
  Binaries:
    Node: 18.18.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.5.2 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.6.0 - C:\Program Files\nodejs\pnpm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Chromium (127.0.2651.74)
  npmPackages:
    @emotion/react: ^11.11.4 => 11.11.4 
    @emotion/styled: ^11.11.5 => 11.11.5 
    @mui/base:  5.0.0-beta.40 
    @mui/core-downloads-tracker:  5.15.17 
    @mui/icons-material: ^5.15.17 => 5.15.17 
    @mui/lab: ^5.0.0-alpha.170 => 5.0.0-alpha.170 
    @mui/material: ^5.15.17 => 5.15.17 
    @mui/private-theming:  5.16.6 
    @mui/styled-engine:  5.16.6 
    @mui/system:  5.16.7 
    @mui/types:  7.2.15 
    @mui/utils:  5.16.6 
    @mui/x-charts: ^7.12.1 => 7.12.1
    @mui/x-charts-vendor:  7.12.1
    @mui/x-data-grid:  7.3.2
    @mui/x-data-grid-pro: ^7.3.2 => 7.3.2
    @mui/x-date-pickers: ^7.4.0 => 7.4.0
    @mui/x-date-pickers-pro: ^7.4.0 => 7.4.0
    @mui/x-license:  7.2.0
    @types/react: ^18.2.66 => 18.2.79
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    typescript: ^5.2.2 => 5.4.5

Search keywords: pickers, time picker
Order ID: 89766

@svidskiy svidskiy added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 13, 2024
@github-actions github-actions bot added component: pickers This is the name of the generic UI component, not the React module! support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/ labels Aug 13, 2024
@svidskiy svidskiy changed the title [pickers] [pickers] Trigger does not work when choosing a time Aug 13, 2024
@svidskiy svidskiy changed the title [pickers] Trigger does not work when choosing a time [pickers] Trigger doesn't work when choosing a time Aug 13, 2024
@michelengelen
Copy link
Member

Hey @svidskiy ... this is expected behavior.
We do determine the fingers on the position of the cursor while dragging.
When leaving the clockface while dragging the finger (and selection) will remain in the position it was last recorded, so if the cursor comes back while still dragging it can pick up again.
It's also only logical that closeOnSelect does not trigger, since there was no selection event fired.
@LukasTy do you have anything to add or more insight into the behavior?

@michelengelen michelengelen changed the title [pickers] Trigger doesn't work when choosing a time [pickers] While dragging outside of the clockface the selection won't trigger Aug 13, 2024
@github-actions github-actions bot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 18, 2024
Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@svidskiy: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@LukasTy
Copy link
Member

LukasTy commented Sep 4, 2024

It's also only logical that closeOnSelect does not trigger, since there was no selection event fired.
LukasTy do you have anything to add or more insight into the behavior?

Thanks for the detailed answer @michelengelen. 🙏
You were on point, I can only confirm that the described behavior is expected.
If the author still thinks there is a problem here, then we need a bit more detailed information on what is expected and when. 😉

@LukasTy LukasTy added the status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/
Projects
None yet
Development

No branches or pull requests

3 participants