Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove createDetectElementResize() replaced with ResizeObserver #9015

Merged
merged 1 commit into from
May 19, 2023
Merged

[core] Remove createDetectElementResize() replaced with ResizeObserver #9015

merged 1 commit into from
May 19, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 16, 2023 •
edited

Implement #7298 (review). I noticed this by chance, looking at something else. #8091 makes this irrelevant.

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! labels May 16, 2023
@mui-bot
Copy link

mui-bot commented May 16, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9015--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 708.5 1,136 708.5 934.7 182.075
Sort 100k rows ms 819.9 1,395.5 1,239.8 1,110.2 196.631
Select 100k rows ms 190.2 413.7 307.2 306.92 71.425
Deselect 100k rows ms 151 382.4 273.5 255.46 85.705

Generated by 🚫 dangerJS against 2f11bca

m4theushw
m4theushw approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally forgot to remove this code.

@oliviertassinari oliviertassinari changed the title [core] Remove dead data grid logic [core] Remove createDetectElementResize logic May 19, 2023
@oliviertassinari oliviertassinari changed the title [core] Remove createDetectElementResize logic [core] Remove createDetectElementResize() replaced with ResizeObserver May 19, 2023
@oliviertassinari oliviertassinari merged commit 8827562 into mui:master May 19, 2023
@oliviertassinari oliviertassinari deleted the remove-dead-code-v6 branch May 19, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @mui-bot @m4theushw