Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select is not triggering on change #16

Closed
StephanWeinhold opened this issue May 31, 2015 · 4 comments
Closed

select is not triggering on change #16

StephanWeinhold opened this issue May 31, 2015 · 4 comments

Comments

@StephanWeinhold
Copy link

When I try to catch a mui-select with jQuery's on('change') nothing happens. Is there a method for this?

@amorey
Copy link
Member

amorey commented May 31, 2015

Hmm... MUI is using the browser's native functionality to select an <option> so I'm surprised that jQuery isn't picking up on change events. I can take a look at it this afternoon. In the mean time, if you can link to an example that would be great.

@StephanWeinhold
Copy link
Author

I know. That's why I'm curious :)
Unfortunately it's an internal page behind our company's firewall. A select is triggering until I add the mui-class to it's parent div.
Thanks! And btw: it took me only two hours and a bit to set up a small page with your framework. I appreciate that!

@amorey
Copy link
Member

amorey commented May 31, 2015

It's great to hear you put something together so quickly! I'd love to hear the good/bad issues you ran into. Did you start with the boilerplate HTML on the home page?

It turns out that to trigger a 'change' event you need to do it manually. I added a 'change' event dispatch to the select component so the jQuery handler should work now:
https://github.com/muicss/mui/blob/master/src/js/forms/select.js#L306

The bugfix is in v0.1.5 if you want to give it a try. Let me know if you run into any more issues!
https://www.muicss.com

@amorey amorey closed this as completed May 31, 2015
@StephanWeinhold
Copy link
Author

Ah, didn't see that. Thanks a lot! Works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants