Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist folder ignored in bower.json #27

Closed
GeoffreyFrogeye opened this issue Jun 26, 2015 · 6 comments
Closed

dist folder ignored in bower.json #27

GeoffreyFrogeye opened this issue Jun 26, 2015 · 6 comments

Comments

@GeoffreyFrogeye
Copy link

I mean, this probably the most useful folder when you use it with bower. Why ignore it?

@amorey
Copy link
Member

amorey commented Jun 26, 2015

Bower is usually used for accessing the source code (e.g. sass) so you can build your own custom distribution:
https://www.muicss.com/docs/v1/css-js/customization

Can you show me an example of where it's useful to access the dist folder from Bower?

@GeoffreyFrogeye
Copy link
Author

It may be useful when developing a small project that doesn't have a build system, so you can use the bower component right after issuing bower install, and you don't have to figure out how to build the component, nor you have to rebuild it each time you run bower install (not that it's difficult, especially with mui). Most components do that (e.g. jquery, bootstrap, d3).

@amorey
Copy link
Member

amorey commented Jun 27, 2015

Is it easier to use the .css files from bower as opposed to hot linking from the CDN? Here's boilerplate which includes links to the CDN:
https://www.muicss.com/docs/v1/css-js/boilerplate-html

It seems like the bootstrap-sass-official bower package only includes the source files:
https://github.com/twbs/bootstrap-sass/blob/master/bower.json

I'm curious to hear more about how you're using bower and why it's more useful to access pre-built distribution files from bower over the CDN or the download package.

@GeoffreyFrogeye
Copy link
Author

I personally prefer to serve the files locally rather than from a CDN, for security and reliability reasons. It's not that I don't trust the CDN, but for developing an application that manipulates sensible data (such as passwords) or can be ran on an infrastructure that may have a proxy which could block the CDN for whatever reason, proceeding this way is better.

Bootstrap-sass doesn't seem to have pre-built files on its git server, however, mui does, which is a good point, because the only obstacle blocking the pre-built files to be included in bower is this little line in bower.json.

Using pre-built files with bower is really useful when you can't/won't use a CDN (e.g. reasons mentioned above), and you can't/won't configure a build system (e.g. for small projects, or when you don't have time to do so). You just have to point yours link and script tags to the correct file in bower_components folder (or whatever name you gave it), and you're good to go. What's more useful, you just can run bower update and all your dependencies are up to date. However, currently with mui I need to use a git submodule, and update it separately, which is less practical than bower.

Let me insist on the fact that's it's only one line to remove, which will benefit some users and won't disturb others (apart from some extra files downloaded, I don't think it's a problem).
It's a matter of opinion, really, so I won't blame anybody if it's not done so 😄.

@amorey
Copy link
Member

amorey commented Jun 28, 2015

Added 'dist' directory to bower.json in v0.1.15 via 45dfd7d

You can also download the pre-built package as a zip file from the MUI website:
https://www.muicss.com

@amorey amorey closed this as completed Jun 28, 2015
@GeoffreyFrogeye
Copy link
Author

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants