Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check the shape of the input dataframe #14

Closed
mukeshmk opened this issue Jun 17, 2020 · 0 comments
Closed

check the shape of the input dataframe #14

mukeshmk opened this issue Jun 17, 2020 · 0 comments
Assignees
@mukeshmk
Labels
bug Something isn't working enhancement New feature or request

Comments

@mukeshmk
Copy link
Owner

complete TODO in predict() function.

check the shape of the input data frame and the shape of the data frame used to train the model, possibly from the class variables?

fm-learn/src/fmlearn.py

Line 63 in fe73f9d

# TODO: check if the shape of the input df matches that used to train the model.

NOTE: handle what would happen if the data is reloaded?
might have to fix #12 before this?
@mukeshmk mukeshmk added bug Something isn't working enhancement New feature or request labels Jun 17, 2020
@mukeshmk mukeshmk self-assigned this Jun 21, 2020
@mukeshmk mukeshmk mentioned this issue Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukeshmk mukeshmk

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mukeshmk