Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect DomainNameBufferOffset/WorkstationBufferOffset values when DomainName/Workstation empty #42

Open
GoogleCodeExporter opened this issue Apr 7, 2015 · 0 comments
Open

Incorrect DomainNameBufferOffset/WorkstationBufferOffset values when DomainName/Workstation empty #42

GoogleCodeExporter opened this issue Apr 7, 2015 · 0 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

In ntlm.py create_NTLM_NEGOTIATE_MESSAGE

WorkstationBufferOffset = BODY_LENGTH when Workstation is empty (len=0)
DomainNameBufferOffset = BODY_LENGTH+WorkstationBufferOffset when DomainName is 
empty

When Workstation or DomainName value is empty, their corresponding BufferOffset 
values should be 0. Otherwise, server can respond with BAD REQUEST status code 
(this happens all the time in my case with some third-party webservice).

Attached patch fixes this issue.

Original issue reported on code.google.com by tadas.da...@gmail.com on 2 Oct 2013 at 1:52

Attachments:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter