Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignTx does not provide AddressN for change addresses on output #7

Closed
gary-rowe opened this issue Nov 25, 2014 · 2 comments
Closed

SignTx does not provide AddressN for change addresses on output #7

gary-rowe opened this issue Nov 25, 2014 · 2 comments
Assignees
@gary-rowe
Milestone
Private Beta 1

Comments

@gary-rowe
Copy link
Contributor

The AddressN entry in a TX_OUTPUT is required to let the Trezor know that this address is a change address (or at least belongs to the wallet). As a result the Trezor will ignore the sign confirmation since no funds will leave the wallet.

The Trezor display will also accurately reflect what the wallet is showing in terms of funds leaving the wallet.
@gary-rowe gary-rowe self-assigned this Nov 25, 2014
@gary-rowe gary-rowe added this to the Private Beta 1 milestone Nov 25, 2014
gary-rowe added a commit that referenced this issue Nov 25, 2014
@gary-rowe
#7 Adding support for change address path map throughout
9876b10
@gary-rowe
Copy link
Contributor Author

Sign transaction now correctly handles change addresses. Verify using TrezorV1WatchingWalletExample in the normal manner.

Ready for review and close.

gary-rowe added a commit that referenced this issue Nov 26, 2014
@gary-rowe
#7 Removed transaction output count from context as change address pa…
4026c43 
…th map covers it
@gary-rowe
Copy link
Contributor Author

This seems to be be working now (several successful transactions) so I'll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gary-rowe gary-rowe

Labels
None yet
Projects
None yet
Milestone
Private Beta 1
Development

No branches or pull requests
1 participant
@gary-rowe