Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord presence shows "out of 0 players" for older servers #1328

Closed
qaisjp opened this issue Mar 27, 2020 · 3 comments · Fixed by #1330
Closed

Discord presence shows "out of 0 players" for older servers #1328

qaisjp opened this issue Mar 27, 2020 · 3 comments · Fixed by #1330
Labels
bug Something isn't working
Milestone

Comments

@qaisjp
Copy link
Contributor

qaisjp commented Mar 27, 2020

Describe the bug

discord presence shows x/0 players when the server is older than the discord presence update

To reproduce

  1. checkout an older master
  2. build server
  3. start server (DO NOT STOP THE SERVER)
  4. checkout latest master
  5. build client
  6. start client and connect to server
  7. observe 1/0 Player in your rich presence

Expected behaviour

It should just say 1 Player

Screenshots

image

Version

client 2e02ebe (master)
server 2d68519 (master^^)

Additional context

valve please fix

@qaisjp qaisjp added the bug Something isn't working label Mar 27, 2020
@qaisjp
Copy link
Contributor Author

qaisjp commented Mar 27, 2020

@0x416c69 if you have the time, please can you fix this? 🙂

@0x416c69
Copy link
Contributor

0x416c69 commented Mar 27, 2020

I think it's better to write this somewhere for people who accept PRs in case they forgot:

Check if the contributor incremented BitStream version and if he did check commits that have been pushed after the pull request and see if they incremented BitStream version too and if there was a commit, update the pull request BitStream version.

Incrementing for my PR which resulting in fixing this issue: #1330

@qaisjp
Copy link
Contributor Author

qaisjp commented Mar 27, 2020

you mean https://github.com/multitheftauto/mtasa-blue/wiki/BitStream ?

i guess we should include a link to that page in the code somewhere

my bad. yes i'll add this to the potentially upcoming contributors guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants