-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of all dxDrawText arguments #2363
Comments
This would also allow to split arguments in few lines, which is cool and more readable. |
it would be even cooler if it was like this |
no, because "createStyle" would return userdata for faster access for c++ |
Does this kill backwards compatibility or its just a more efficent way to run dxDrawText? If it's the latter I like this idea, but if it's the former then I'm against it. What I mean with a more efficent way to run dxDrawText is that you have this way, with styles, and another way which is the current one. Seeing that draw functions are really slow we should try to get the most of it as possible. The real rn alternative is using renderTargets, which can improve the performance a lot and are pretty simple to implement, but they also have some sidedowns. |
my approach with userdata at second argument is easy to make compatibile with older versions, it also make it faster due you already keep in memory all properties you want |
@CrosRoad95 make a pull request to that |
I dont think we want this. Theres an extension for VSC with MTA function syntax, use that + function argument labels. |
Is your feature request related to a problem? Please describe.
Too many arguments
Describe the solution you'd like
make option to create some style userdata to pass it into dxDrawText class
pseudocode:
Describe alternatives you've considered
No alternative
Additional context
For years this function grown in amount of arguments, this function keep getting harder and harder to use.
Also this amount of checks cause function to be slower as well
The text was updated successfully, but these errors were encountered: