Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rc/v1.6.0 in feat/balance data tries 24may #5279

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

  • Merge rc/v1.6.0 in feat/balance-data-tries

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

BeniaminDrasovean and others added 30 commits October 13, 2022 09:00
…-missing-trie-nodes

Merge rc v1.4.0 feat sync missing trie nodes
BeniaminDrasovean and others added 21 commits May 18, 2023 12:19
…-missing-trie-nodes-18may

Merge rc/v1.6.0 in feat/sync missing trie nodes 18may
…in-feat/balance-data-trie-23may

# Conflicts:
#	factory/processing/blockProcessorCreator.go
#	factory/processing/blockProcessorCreator_test.go
#	factory/processing/export_test.go
#	factory/processing/processComponents.go
#	go.mod
#	go.sum
…nce-data-trie-23may

Merge rc/v1.6.0 in feat/sync missing trie nodes 23may
…in-feat/balance-data-tries-24may

# Conflicts:
#	dataRetriever/factory/storageRequestersContainer/baseRequestersContainerFactory.go
#	dataRetriever/factory/storageRequestersContainer/metaRequestersContainerFactory.go
#	dataRetriever/factory/storageRequestersContainer/shardRequestersContainerFactory.go
#	epochStart/metachain/baseRewards_test.go
#	epochStart/metachain/systemSCs_test.go
#	errors/errors.go
#	factory/processing/blockProcessorCreator_test.go
#	factory/state/stateComponents.go
#	genesis/process/genesisBlockCreator.go
#	genesis/process/genesisBlockCreator_test.go
#	go.mod
#	go.sum
#	integrationTests/benchmarks/loadFromTrie_test.go
#	integrationTests/state/stateTrieClose/stateTrieClose_test.go
#	integrationTests/testProcessorNode.go
#	integrationTests/vm/testInitializer.go
#	state/accountsDB.go
#	state/syncer/errors.go
#	testscommon/components/components.go
#	trie/branchNode.go
#	trie/branchNode_test.go
#	trie/doubleListSync_test.go
#	trie/errors.go
#	trie/extensionNode.go
#	trie/extensionNode_test.go
#	trie/factory/trieCreator.go
#	trie/factory/trieCreator_test.go
#	trie/interface.go
#	trie/leafNode.go
#	trie/patriciaMerkleTrie.go
#	trie/patriciaMerkleTrie_test.go
#	trie/trieStorageManager_test.go
#	update/genesis/import.go
@BeniaminDrasovean BeniaminDrasovean added the ignore-for-release-notes Do not include item in release notes label May 24, 2023
BeniaminDrasovean and others added 3 commits May 25, 2023 11:07
…in-feat/balance-data-tries-24may

# Conflicts:
#	go.mod
#	go.sum
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 87.90% and project coverage change: +1.95 🎉

Comparison is base (e28ff0f) 77.44% compared to head (450b44e) 79.40%.

❗ Current head 450b44e differs from pull request most recent head e4e66c3. Consider uploading reports for the commit e4e66c3 to get more accurate results

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/balance-data-tries    #5279      +/-   ##
===========================================================
+ Coverage                    77.44%   79.40%   +1.95%     
===========================================================
  Files                          682      693      +11     
  Lines                        88995    89843     +848     
===========================================================
+ Hits                         68926    71337    +2411     
+ Misses                       14678    13261    -1417     
+ Partials                      5391     5245     -146     
Impacted Files Coverage Δ
api/middleware/responseLogger.go 66.66% <0.00%> (ø)
cmd/keygenerator/converter/pidPubkeyConverter.go 90.47% <ø> (ø)
...termui/view/termuic/termuiRenders/widgetsRender.go 2.94% <0.00%> (-0.04%) ⬇️
consensus/spos/bls/subroundStartRound.go 68.36% <0.00%> (ø)
epochStart/shardchain/trigger.go 65.89% <0.00%> (ø)
factory/core/coreComponents.go 90.19% <ø> (+10.78%) ⬆️
factory/crypto/cryptoComponents.go 79.69% <ø> (+3.66%) ⬆️
factory/processing/txSimulatorProcessComponents.go 75.80% <ø> (ø)
factory/state/stateComponents.go 79.35% <ø> (+11.69%) ⬆️
factory/state/stateComponentsHandler.go 86.91% <ø> (+25.29%) ⬆️
... and 79 more

... and 69 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeniaminDrasovean BeniaminDrasovean merged commit 1f61f5d into feat/balance-data-tries May 25, 2023
4 checks passed
@BeniaminDrasovean BeniaminDrasovean deleted the merge-rc/v1.6.0-in-feat/balance-data-tries-24may branch May 25, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants