Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show no talents found when no talents after filter #48

Closed
NitinMa2 opened this issue Apr 3, 2021 · 0 comments · Fixed by #91
Closed

Show no talents found when no talents after filter #48

NitinMa2 opened this issue Apr 3, 2021 · 0 comments · Fixed by #91
Labels
enhancement Improvement of existing feature first timers only Super easy issue to fix if you've never contributed to open source before good first issue Good for newcomers

Comments

@NitinMa2
Copy link
Contributor

NitinMa2 commented Apr 3, 2021

Knowledge of conditional rendering is required.

image

On the talent page, when you enter multiple filters and there is no talent to display, we want to show some text instead of leaving the screen blank. This improves the UX of the platform.

Steps to accomplish the task:
1, If you haven't done already, create a new branch that you'll make your changes on.
2. Navigate to the file, src/views/FindTalent.vue
3. The array variable filteredTalent is used to display the talent. If the length of this array is 0, display some placeholder text instead. You can decide on what to display.
4. Follow the steps to submit your PR.

@NitinMa2 NitinMa2 added enhancement Improvement of existing feature good first issue Good for newcomers first timers only Super easy issue to fix if you've never contributed to open source before labels Apr 3, 2021
@NitinMa2 NitinMa2 linked a pull request Jul 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature first timers only Super easy issue to fix if you've never contributed to open source before good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant