Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ServerHandler: do not send pings unless the TLS handshake has completed.
sss123next in #3294 reports that the current ping timer logic causes problems with slow TLS handshakes, such as when connecting to servers with large DH parameters. This commit ensures pings are not sent before the TLS handshake has completed. This was tested against a Grumble instance built against a modified crypto/tls package that sleeps during the handshake. I verified that isEncrypted() returns false when the handshake has not finished, and returns true when the handshake has completed.
- Loading branch information