-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access Tokens Rejected When Disconnect and Reconnect to Server #6334
Comments
This sounds like a duplicate of #5907 which has been fixed on the master branch. Since that would be a server-side issue, updating the server to the latest master commit should fix this. Please report back, if that fixes the issue. |
I rebuild docker image with latest MUMBLE_VERSION tag, delete server sqlite db, clean run server (no existing/previous server config), create only 2 test channel. Problem still persist. Here's my Dockerfile:
Here's my docker run command:
|
What version number does this server report (under server information)? |
Hm alright. In that case it seems like there is either another bug very similar to #5907 or another facet to this bug that has not yet been addressed 🤔 |
Can reproduce. Only affects unregistered users |
In 635d719 cache invalidation for access tokens was added. A check for ``uSource->iId >= 0`` was added which was intended to only parse access tokens, if the ``authenticate`` method was not returning an error code. As it turns out though, ``uSource->iId`` will be -1 for unREGISTERED users instead of unAUTHENTICATED users which lead to a bug where unregistered users would not have the correct channel access when connecting to the server. A subsequent update of their tokens would fix that. This commit moves the respective code block down and changes the condition to ``ok``, which should now behave as originally intended. Fixes mumble-voip#6334
In 635d719 cache invalidation for access tokens was added. A check for ``uSource->iId >= 0`` was added which was intended to only parse access tokens, if the ``authenticate`` method was not returning an error code. As it turns out though, ``uSource->iId`` will be -1 for unREGISTERED users instead of unAUTHENTICATED users which lead to a bug where unregistered users would not have the correct channel access when connecting to the server. A subsequent update of their tokens would fix that. This commit moves the respective code block down and changes the condition to ``ok``, which should now behave as originally intended. Fixes mumble-voip#6334
In 635d719 cache invalidation for access tokens was added. A check for ``uSource->iId >= 0`` was added which was intended to only parse access tokens, if the ``authenticate`` method was not returning an error code. As it turns out though, ``uSource->iId`` will be -1 for unREGISTERED users instead of unAUTHENTICATED users which lead to a bug where unregistered users would not have the correct channel access when connecting to the server. A subsequent update of their tokens would fix that. This commit moves the respective code block down and changes the condition to ``ok``, which should now behave as originally intended. Fixes mumble-voip#6334
The issue
With right Access Tokens, when client disonnect and connect again, entering any password protected channel always denied, must open Access Tokens window and click OK and then enter the channel (in Mumble App for windows), and in Mumla must open Access Tokens menu and add another token entry to get working. Very annoying for non-technical clients
Mumble Windows Client version 1.4.287, tried on multiple PC
Mumla Android Client version 3.6.7 (Android 12 and 13), tried on multiple android device
Server Version: 1.6.287 (Official Docker Builds)
Maybe existing client's access tokens data not sent to server when connecting/entering channel?
Mumble version
1.6.287
Mumble component
Both
OS
Linux, Windows
Additional information
No response
The text was updated successfully, but these errors were encountered: