FIX(server): Allow unregistered users to transmit access tokens #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 635d719 cache invalidation for access tokens was added. A check for ``uSource->iId >= 0`` was added which was intended to only parse access tokens, if the ``authenticate`` method was not returning an error code. As it turns out though, ``uSource->iId`` will be -1 for unREGISTERED users instead of unAUTHENTICATED users which lead to a bug where unregistered users would not have the correct channel access when connecting to the server. A subsequent update of their tokens would fix that. This commit moves the respective code block down and changes the condition to ``ok``, which should now behave as originally intended. Fixes mumble-voip#6334
Krzmbrzl
approved these changes
Feb 13, 2024
davidebeatrici
approved these changes
Feb 13, 2024
|
One more reason to get rid of special IDs such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 635d719 cache invalidation for access tokens was added. A check for
uSource->iId >= 0was added which was intended to only parse access tokens, if theauthenticatemethod was not returning an error code.As it turns out though,
uSource->iIdwill be -1 for unREGISTERED users instead of unAUTHENTICATED users which lead to a bug where unregistered users would not have the correct channel access when connecting to the server. A subsequent update of their tokens would fix that.This commit moves the respective code block down and changes the condition to
ok, which should now behave as originally intended.Fixes #6334