Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing grayed out with closed mouth icon #3037

Merged
merged 1 commit into from May 31, 2017

Conversation

@ghost
Copy link

commented Apr 17, 2017

This replaces a grayed out mouth icon with a grayed out but closed mouth icon.

mray
Replacing grayed out with closed mouth icon
This replaces a grayed out mouth icon with a grayed out but *closed* mouth icon.
@ghost ghost referenced this pull request Apr 17, 2017
@mkrautz

This comment has been minimized.

Copy link
Member

commented Apr 21, 2017

I've tried playing with this, and I think I prefer the open mouth to be honest.

I also feel that with the the smaller, closed mouth, it is harder to figure out what the shape is supposed to be. But that might just be because I'm used to the old icon.

Not against this change -- since I think it's mostly a case of what I'm used to -- but I'm curious what other people think. @hacst, @Kissaki?

Also, @mray, you are aware that the mouth icon is only used in the classic theme, not the new light/dark themes, which do not use a mouth icon for the speaker state.

@ghost

This comment has been minimized.

Copy link
Author

commented Apr 21, 2017

@mkrautz I'm not aware of what the "default" theme is, I just use what's in my repo (1.2.18-1) and it works fine. Where can I change to light/dark themes?
My motivation was that I repeatedly found myself checking for colors in the roster to see if somebody is speaking but I'm not hearing anything. I didn't get why a "shut" mouth should be an open, but grayed out one, since the change in shape would be noticable much more.

@mkrautz

This comment has been minimized.

Copy link
Member

commented Apr 23, 2017

The new themes are not in a release yet. They're part of the upcoming 1.3.0 release. Builds are available for some platforms at https://www.mumble.info.

@davidebeatrici
Copy link
Member

left a comment

I like the idea.
In my opinion, using the same icon with different colors is confusing.

@davidebeatrici

This comment has been minimized.

Copy link
Member

commented May 31, 2017

As @mkrautz said, this only affects the old theme, but I think the change is worth it anyway.

@mkrautz mkrautz merged commit d1baf4f into mumble-voip:master May 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.