ServerHandler: do not send pings unless the TLS handshake has completed. #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was tested against a Grumble instance built against a modified crypto/tls that sleeps during the handshake. I verified that isEncrypted() returns false when the handshake has not finished, and returns true when the handshake has completed. |
sss123next in mumble-voip#3294 reports that the current ping timer logic causes problems with slow TLS handshakes, such as when connecting to servers with large DH parameters. This commit ensures pings are not sent before the TLS handshake has completed. This was tested against a Grumble instance built against a modified crypto/tls package that sleeps during the handshake. I verified that isEncrypted() returns false when the handshake has not finished, and returns true when the handshake has completed.
mkrautz
force-pushed
the
serverhandler-timer-fixes
branch
from
3601e2d
to
d188861
Compare
|
Added my testing methodology to the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sss123next in #3294 reports that the current ping
timer logic causes problems with slow TLS handshakes, such as when
connecting to servers with large DH parameters.
This commit ensures pings are not sent before the TLS handshake has
completed.