ServerHandler, Settings: add ping interval and connection timeout duration settings. #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrautz
force-pushed
the
serverhandler-timeout-settings
branch
from
1bfdeeb
to
fe4f665
Compare
hacst
approved these changes
Jan 14, 2018
src/mumble/Settings.h
Outdated
| @@ -331,6 +331,18 @@ struct Settings { | |||
| ProxyType ptProxyType; | |||
| QString qsProxyHost, qsProxyUsername, qsProxyPassword; | |||
| unsigned short usProxyPort; | |||
|
|
|||
| /// The ping interval in milliseconds. The Mumble client | |||
| /// will send TCP and UDP pings to the remote server at this | |||
mkrautz
force-pushed
the
serverhandler-timeout-settings
branch
from
fe4f665
to
536076c
Compare
|
I changed the wording of the comment. |
davidebeatrici
approved these changes
Jan 14, 2018
… duration. This commit implements (hidden, for now) settings for setting the ping interval and connection timeout duration.
… Settings instead of magic numbers.
mkrautz
force-pushed
the
serverhandler-timeout-settings
branch
from
536076c
to
97d776a
Compare
|
Rebased on top of the PR to use our own MXE mirror to speed up the MinGW builds. (#3305) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits:
Settings: implement settings for ping interval and connection timeout duration., which adds the necessary plumbing to the Settings class.ServerHandler: use ping interval and connection timeout duration from Settings instead of magic numbers., which hooks up ServerHandler to use the new values from the Settings class.