You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the Mun Runtime receives RuntimeOptions from the RuntimeBuilder in order to load a shared library. At the moment this library path is not platform agnostic (i.e. internally determines whether it is dealing with a *.so OR *.dll OR *.dylib file). This results in code like this (a contrived example):
fnruntime_unix() -> Runtime{RuntimeBuilder::new("voxygen/src/anim/character/test.so").spawn().expect("Failed to spawn Runtime");}fnruntime_windows() -> Runtime{RuntimeBuilder::new("voxygen/src/anim/character/test.dll").spawn().expect("Failed to spawn Runtime");}
Per @sonovice's submission, we want to instead generate libraries with a custom extension: *.munlib:
fnruntime() -> Runtime{RuntimeBuilder::new("voxygen/src/anim/character/test.munlib").spawn().expect("Failed to spawn Runtime");}
To implement this, you need to:
replace *.so / *.dll / *.dylib extensions with *.munlib in the Mun Compiler when writing to file
check that RuntimeBuilder::new is allowed to receive any path (both with and without extension)
start a Pull Request. Set description to closes #72. If this is your first PR, welcome 🎉 😄
The text was updated successfully, but these errors were encountered:
cargo test
)Runtime
receivesRuntimeOptions
from theRuntimeBuilder
in order to load a shared library. At the moment this library path is not platform agnostic (i.e. internally determines whether it is dealing with a *.so OR *.dll OR *.dylib file). This results in code like this (a contrived example):*.munlib
:RuntimeBuilder::new
is allowed to receive any path (both with and without extension)closes #72
. If this is your first PR, welcome 🎉 😄The text was updated successfully, but these errors were encountered: