misc: fix windows libclang issues #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
force-pushed
the
fix/windows_build
branch
6 times, most recently
from
9386f21
to
f17f4d8
Compare
…led libclang version
baszalmstra
force-pushed
the
fix/windows_build
branch
2 times, most recently
from
f12bddd
to
daee113
Compare
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 82.94% 82.95%
=======================================
Files 163 163
Lines 11509 11514 +5
=======================================
+ Hits 9546 9551 +5
Misses 1963 1963
Continue to review full report at Codecov.
|
Wodann
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the windows builds. It was broken because GitHub added msys64 to their windows environments which include a copy of libclang. Using that however, resulted in an error.
This PR adds the LIBCLANG_PATH environment variable when installing LLVM on windows. That way it uses libclang from the version of LLVM we install anyway.