Add support for CPU and Memory Sandboxing #388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #if WREN_SANDBOX | ||
| /// Specifies the maximum number of virtual machine instructions to execute, this | ||
| /// field is only used when WREN_ |
There was a problem hiding this comment.
This comment appears to have been truncated.
|
Is there an RFC or a specification that you're implementing here? |
|
@acook I haven't implemented any specific specification, I am just looking for ways to run untrusted code in a deterministic manner. I will clean up the patch and try to get it passing unit tests. |
|
Superseded by #393. Note that you can update existing pull requests by force-pushing ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed set of changes allow WREN to be built with WREN_SANDBOX defined. When this is defined the WrenConfig object will have two extra parameters:
Every time memory is allocated or an op is executed a counter is incremented. The program will halt if it runs too long or too much memory is allocated.
These changes are part of work that would enable WREN to be used as a Crypto Currency Virtual Machine. If adopted with use in a crypto currency, WREN would likely get much more attention and developer interest.