Plugin memory (linux): use fixed colors for all fields #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only the color for the field "apps" was fixed (green). The colors of all remaining fields depended on the local setup of the host and the resulting availability of various memory-related statistics (e.g. "shmem"). A change of setup or a kernel upgrade thus lead to a confusing shift of the color palette. An unfortunate environment would even lead to the field "free" using the "red" color from the palette. This warning colour would obviously be misleading. The memory plugin will not be maintained in the long term. It is already removed from the branch preparing the upcoming munin 3.0 release. Thus it is acceptable to introduce a fixed color scheme, even though this would usually be a maintenance burden. Please note that the colors of almost all fields may change (once). Definitely unchanged fields: * apps (always the first field) * KSM sharing (previously hard-coded) Most other fields are *probably* unchanged for systems where the fields "page_tables", "swap_cache" and "slab_cache" are available. Users of systems with a different set of optional memory related statistics will experience a one-time shift of the color palette for their set of available fields.
Previous color set (for an example setup)
New color set
|
|
I tend to agree on that PR, but we have to ensure that the colors will remain stable in the 3.0 plugin rewrite. |
steveschnepp
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the color for the field "apps" was fixed (green). The colors of all remaining fields depended on the local setup of the host and the resulting availability of various memory-related statistics (e.g. "shmem"). A change of setup or a kernel upgrade thus lead to a confusing shift of the color palette. An unfortunate environment would even lead to the field "free" using the "red" color from the palette. This warning colour would obviously be misleading.
The memory plugin will not be maintained in the long term. It is already removed from the branch preparing the upcoming munin 3.0 release. Thus it is acceptable to introduce a fixed color scheme, even though this would usually be a maintenance burden.
Please note that the colors of almost all fields may change (once).
Definitely unchanged fields:
Most other fields are probably unchanged for systems where the fields "page_tables", "swap_cache" and "slab_cache" are available.
Users of systems with a different set of optional memory related statistics will experience a one-time shift of the color palette for their set of available fields.