Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard patch #120 Cymbal is emulated incorrectly with old-gen MT-32 control ROMs #82

Closed
sergm opened this issue Jan 4, 2022 · 0 comments
Closed

Standard patch #120 Cymbal is emulated incorrectly with old-gen MT-32 control ROMs #82

sergm opened this issue Jan 4, 2022 · 0 comments
Assignees
@sergm
Labels
Bug libmt32emu
Milestone
libmt32emu_2_6

Comments

@sergm
Copy link
Member

sergm commented Jan 4, 2022 •
edited
Loading

NewRisingSun reports about incorrect emulation wrt. slower decay and rather abrupt termination when playing said patch. Apparently, this is easily reproducible by just a ProgramChange-NoteOn sequence sent after a reset, like this:

TIMESTAMP IN PORT STATUS DATA1 DATA2 CHAN NOTE EVENT
 00003697  MOX  2     C1    77    --    2  ---  PC: Cymbal    
 00004335  KEY  2     91    3C    64    2  C  4 Note On

See VOGONS topic for more background.
@sergm sergm added this to the libmt32emu_2_6 milestone Jan 4, 2022
@sergm sergm self-assigned this Jan 4, 2022
sergm added a commit that referenced this issue Jan 8, 2022
@sergm
mt32emu: Fixed emulation of quirkTVAZeroEnvLevels
3486106 
As shown by tests using partials with various TVA envelopes, the old-gen
devices exhibit a TVA quirk when playing a partial with zero TVA ENV LEVEL
1-3, but in case of zero TVA ENV SUSTAIN LEVEL the behaviour is identical
to the new-gen units. (#82)
@sergm sergm closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergm sergm

Labels
Bug libmt32emu
Projects
None yet
Milestone
libmt32emu_2_6
Development

No branches or pull requests
1 participant
@sergm