Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Link to an issue through commit messages #233

Closed
8 of 9 tasks
philou opened this issue Feb 1, 2023 · 0 comments · Fixed by #248
Closed
8 of 9 tasks

[Feature]: Link to an issue through commit messages #233

philou opened this issue Feb 1, 2023 · 0 comments · Fixed by #248
Assignees
Labels
enhancement New feature or request murex Items related to using TCR at Murex S Small

Comments

@philou
Copy link
Contributor

philou commented Feb 1, 2023

Contact Details

No response

Feature Request

At the moment, it is not possible to link a TCR commit to any issue (Github, Jira, or whatever).

Feature Description

The standard way to link a commit with an issue is by adding an issue ID tag in the commit message (#xxx). Convention Commits suggests adding this meta-information in the footer https://www.conventionalcommits.org/en/v1.0.0-beta.2/

We will provide a new command line option to specify a suffix to all commit messages. We'll append the suffix as a new line at the end of the commit message footer, without any modification. Ex:

Running: tcr --message-suffix "Issue #999999"

✅ TCR - tests passing

changed-lines:
    src: 3
    test: 0
test-stats:
    run: 11
    passed: 11
    failed: 0
    skipped: 1
    error: 0
    duration: 0s

Issue #999999

We will not allow to provide this value from the config, to avoid 'forgetting' about it.
Users will have to stop and start TCR again if they want to change the commit message suffix.

Alternatives

We have been thinking where to put this issue tag in the message, and envisioned a title prefix, a first line, or even making it configurable. We decided to stick to Conventional Commits.

Additional Context

Write your answer here.

Code of Conduct

  • I agree to follow this project's Code of Conduct

To Do

  • Add new command line interface parameter
    • Ensure the parameter is not persisted in the configuration
  • Update the commit messages with the value of the 'message-suffix'
    • If 'message-suffix' is not provided we should not change the default behavior
  • Separate the stats from the message footer
  • Display suffix message in session summary when entering TCR
  • Update the documentation for this option (will be done through the setup of the new command line parameter)

Warning

  • ⚠ Using this feature with suffix message containing space characters will require to evolve tcrw scripts so that command line parameters containing spaces are properly forwarded to the TCR executable
@philou philou added the enhancement New feature or request label Feb 1, 2023
@philou philou assigned philou, mengdaming and aatwi and unassigned philou Feb 1, 2023
@philou philou added the S Small label Feb 1, 2023
aatwi pushed a commit that referenced this issue Feb 1, 2023
philou added a commit that referenced this issue Feb 8, 2023
To link a TCR commit to an issue in issue tracker
@philou philou mentioned this issue Feb 8, 2023
5 tasks
@philou philou linked a pull request Feb 8, 2023 that will close this issue
5 tasks
philou pushed a commit that referenced this issue Feb 8, 2023
philou added a commit that referenced this issue Feb 8, 2023
To link a TCR commit to an issue in issue tracker
@philou philou added the murex Items related to using TCR at Murex label Feb 15, 2023
philou added a commit that referenced this issue Feb 15, 2023
To be able to diagnose P4 setup issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request murex Items related to using TCR at Murex S Small
Development

Successfully merging a pull request may close this issue.

3 participants