Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: tcr solo crashes trying to launch the periodic reminder #54

Closed
1 task done
mengdaming opened this issue May 18, 2022 · 0 comments
Closed
1 task done

[Bug]: tcr solo crashes trying to launch the periodic reminder #54

mengdaming opened this issue May 18, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mengdaming
Copy link
Contributor

Contact Details

damien.menanteau@gmail.com

Describe the bug

When running tcr in solo mode, TCR crashes trying to launch the periodic reminder.

The problem exists on the following releases:

  • v0.13.0
  • v0.14.0

To Reproduce

Steps to reproduce the behavior:

  1. Make sure to use tcr version 0.13.0 or 0.14.0
  2. Run tcr solo
  3. error trace with tcr 0.13.0:

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x8 pc=0x9a1b0e]

goroutine 51 [running]:
github.com/murex/tcr/tcr-engine/timer.(*PeriodicReminder).Start(0x0)
/home/runner/work/TCR/TCR/tcr-engine/timer/periodic_reminder.go:105 +0x2e
github.com/murex/tcr/tcr-engine/engine.(*TcrEngine).RunAsDriver.func1()
/home/runner/work/TCR/TCR/tcr-engine/engine/tcr.go:192 +0xb6
github.com/murex/tcr/tcr-engine/engine.(*TcrEngine).fromBirthTillDeath.func1()
/home/runner/work/TCR/TCR/tcr-engine/engine/tcr.go:260 +0x38
gopkg.in/tomb%2ev2.(*Tomb).run(0xc0001ec0f0, 0x0)
/home/runner/go/pkg/mod/gopkg.in/tomb.v2@v2.0.0-20161208151619-d5d1b5820637/tomb.go:163 +0x36
created by gopkg.in/tomb%2ev2.(*Tomb).Go
/home/runner/go/pkg/mod/gopkg.in/tomb.v2@v2.0.0-20161208151619-d5d1b5820637/tomb.go:159 +0xf3

Expected behavior

TCR should not launch any timer when running in solo mode

Working Environment

  1. OS: any

  2. Versions

  • v0.13.0
  • v0.14.0

Additional Context

Additional information

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mengdaming mengdaming added the bug Something isn't working label May 18, 2022
@mengdaming mengdaming self-assigned this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant