fixes nanomsg#25 Port IsClient/IsServer redundant?

fixes nanomsg#26 Port RemoteProtocol and LocalProtocol are mostly useless

impl/pipe.go

@@ -144,26 +144,16 @@ func (p *pipe) IsOpen() bool {
 	return p.p.IsOpen()
 }
 
-func (p *pipe) IsClient() bool {
-	return p.d != nil
-}
-
-func (p *pipe) IsServer() bool {
-	return p.l != nil
-}
-
-func (p *pipe) LocalProtocol() uint16 {
-	return p.p.LocalProtocol()
-}
-
-func (p *pipe) RemoteProtocol() uint16 {
-	return p.p.RemoteProtocol()
-}
-
 func (p *pipe) Dialer() mangos.Dialer {
+	if p.d == nil {
+		return nil
+	}
 	return p.d
 }
 
 func (p *pipe) Listener() mangos.Listener {
+	if p.l == nil {
+		return nil
+	}
 	return p.l
 }

port.go

@@ -36,18 +36,6 @@ type Port interface {
 	// Note that if a dialer is present and active, it will redial.
 	Close() error
 
-	// IsServer returns true if the connection is from a server (Listen).
-	IsServer() bool
-
-	// IsClient returns true if the connection is from a client (Dial).
-	IsClient() bool
-
-	// LocalProtocol returns the local protocol number.
-	LocalProtocol() uint16
-
-	// RemoteProtocol returns the remote protocol number.
-	RemoteProtocol() uint16
-
 	// Dialer returns the dialer for this Port, or nil if a server.
 	Dialer() Dialer
 

test/common_test.go

@@ -321,11 +321,11 @@ func (c *T) RecvStart() bool {
 		c.Errorf("Got unexpected message port address: %s", addr)
 		return false
 	}
-	if c.IsServer() && !m.Port.IsServer() {
+	if c.IsServer() && m.Port.Listener() == nil {
 		c.Errorf("Expected message port server")
 		return false
 	}
-	if !c.IsServer() && !m.Port.IsClient() {
+	if !c.IsServer() && m.Port.Dialer() == nil {
 		c.Errorf("Expected message port client")
 		return false
 	}

test/porthook_test.go

@@ -67,8 +67,13 @@ type hooktest struct {
 }
 
 func (h *hooktest) Hook(action mangos.PortAction, p mangos.Port) bool {
-	h.t.Logf("Hook called - %v!", action)
-	i := hookinfo{action: action, addr: p.Address(), isopen: p.IsOpen(), server: p.IsServer()}
+	h.t.Logf("Hook called - %v", action)
+	i := hookinfo{
+		action: action,
+		addr:   p.Address(),
+		isopen: p.IsOpen(),
+		server: p.Listener() != nil,
+	}
 	h.Lock()
 	h.calls = append(h.calls, i)
 	h.Unlock()