Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a heap/priority queue for the aio timeouts #25

Closed
gdamore opened this issue Jul 18, 2017 · 1 comment
Closed

Consider a heap/priority queue for the aio timeouts #25

gdamore opened this issue Jul 18, 2017 · 1 comment
Assignees
@gdamore
Labels
enhancement

Comments

@gdamore
Copy link
Contributor

gdamore commented Jul 18, 2017

The AIO timeout logic uses a really naive sorted list for ordering timeouts. This can lead to some pretty unfortunate performance impacts (O(n)). A priority heap would be faster for insertion by far. (Note that running the timeout thread is still O(1) with the linked list, and would remain so with any sane heap implementation.)
@gdamore gdamore self-assigned this Jul 20, 2017
@gdamore
Copy link
Contributor Author

gdamore commented Sep 26, 2017

I think #34 covers this already.

@gdamore gdamore closed this as completed Sep 26, 2017
muryliang pushed a commit to muryliang/nng that referenced this issue Mar 30, 2023
@gdamore
fixes nanomsg#25 Port IsClient/IsServer redundant?
760ba34 
fixes nanomsg#26 Port RemoteProtocol and LocalProtocol are mostly useless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdamore gdamore

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdamore