Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making Windows use threadpools #26

Closed
gdamore opened this issue Jul 18, 2017 · 3 comments
Closed

Consider making Windows use threadpools #26

gdamore opened this issue Jul 18, 2017 · 3 comments

Comments

@gdamore
Copy link
Contributor

gdamore commented Jul 18, 2017

Thread Pools offer some attractive benefits over raw I/O completion ports, including a simpler programming model and better automatic scaling. We might be able to use these to handle taskq type tasks too!

@gdamore
Copy link
Contributor Author

gdamore commented May 30, 2018

This may be required for some kinds of Windows applications. Apparently at least Windows Store 8.1 apps are not permitted to use _beginthreadex....

@gdamore
Copy link
Contributor Author

gdamore commented Jul 13, 2018

I have some mixed data here. Apparently threadpoolio is "new", with almost non-existent documentation and examples. Worse, the I/O threadpools seem to assume that you only really want one outstanding operation on a file handle at a time, which seems (to my mind) to make them less scalable than the underlying IOCP. They are also implemented on top of IOCP, so adding a layer of indirection is unlikely to yield better performance.

I'm shelving this for now. If we need something for Windows Store 8.1 apps, we'll revisit.

@gdamore
Copy link
Contributor Author

gdamore commented Nov 12, 2020

Closing this -- we're not going to do it for the reasons given above.

@gdamore gdamore closed this as completed Nov 12, 2020
muryliang pushed a commit to muryliang/nng that referenced this issue Mar 30, 2023
fixes nanomsg#26 Port RemoteProtocol and LocalProtocol are mostly useless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant