Fix #18573: Doubled articulation prevention #19547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Sep 28, 2023
mathesoncalum
force-pushed
the
18573-prevent_double_artics
branch
2 times, most recently
from
afc96a4
to
c8b1037
Compare
mathesoncalum
force-pushed
the
18573-prevent_double_artics
branch
from
c8b1037
to
fa24d7b
Compare
cbjeukendrup
approved these changes
Oct 2, 2023
|
@oktophonie It might be good to retest this one, since it has changed quite a bit since your initial approval |
oktophonie
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18573