Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mu3 score reported as broken in Mu4 #20400

Closed
Jojo-Schmitz opened this issue Dec 11, 2023 · 16 comments · Fixed by #20521
Closed

Mu3 score reported as broken in Mu4 #20400

Jojo-Schmitz opened this issue Dec 11, 2023 · 16 comments · Fixed by #20521
Labels
regression MS3 Regression from MS3 (3.6.2)

Comments

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Dec 11, 2023

Issue type

Import/export issue

Bug description

No response

Steps to reproduce

The attached (zipped) score
bongo esp.zip
opens fine in Mu3(.6.2), but in Mu4(1.1 at least and later) it reports:
Error=XML_ERROR_EMPTY_DOCUMENT ErrorID=13 (0xd) Line number=0

Extracting the mscx, and importing that in Mu4 works just fine.
As does opening and resaving with Mu3 and importing that in Mu4

Edit: As does renaming the mscz file to fully match the name of the mscx inside.

Screenshots/Screen recordings

No response

MuseScore Version

4.1.1, 4.2.0 Beta and latest master

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows 11

Additional context

Culprit seems to be the name of the mscx, "..bongo español.mscx", or its encoding (esp. that of the "ñ"?) in META-INF/container.xml, as ""

Originally came up in https://musescore.org/en/node/357693

Edit: the real culprit seems the mcsz filename originally starting with 2 dots (and the mscx internally still does), but got those dots 'renamed away'

@muse-bot muse-bot added the regression MS3 Regression from MS3 (3.6.2) label Dec 11, 2023
@cbjeukendrup
Copy link
Contributor

I can confirm that it opens fine in MS3, while in BBEdit (which I normally use for quickly viewing the contents of mscz files) the main mscx doesn't show up at all. So the ZIP is perhaps a little bit corrupted, or maybe indeed some decoders are unhappy about the ñ...

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 11, 2023

7Zip opens it just fine, as does the built-in zip in Windows explorer

@cbjeukendrup
Copy link
Contributor

macOS built-in zip utility too; but the file appears as a hidden file, because the filename starts with two dots
Scherm­afbeelding 2023-12-11 om 12 00 24

@Jojo-Schmitz
Copy link
Contributor Author

Yes, those dots are an additional problem on Mac and Linux

@krtschil
Copy link

Changing the special characters (the dots and the spanisch character) in the zip file does not change the behaviour. Muse 4.1.1 does not open it.
When I extract the .mscx file it will open in Musescore correctly without an error message.

I saved this to a new file and looked at the content. Different from the original one from the original poster and opens in Musescore without problems.
(I am on Linux)
bongo2.mscz.zip

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 11, 2023

Of colurse not, you'd need to change the mscx filename (in the archive) and the corresponding entry in META_INF/container.xml. If you'd do, it'd work, I've tested that
That the plain (extracted) mscx file loads is mentioned in the initial post ;-)

@krtschil
Copy link

I did that in all the places ...

@Jojo-Schmitz
Copy link
Contributor Author

OK, that did work when I tried

@mercuree
Copy link
Contributor

mercuree commented Dec 16, 2023

This file opens fine in MU4 if you rename bongo esp.mscz to ..bongo español.mscz (same name as mscx file inside archive)
Unicode character in filename has no effect to this issue (at least on my system win10)
It also means that we can simply reproduce this "corruption" in MU4. Just create new musescore file and save with file name started with dots. Then rename file to anything else and it becomes corrupted.

@Jojo-Schmitz
Copy link
Contributor Author

It is not the MSCZ filename itself, but the filenames inside the MSCZ

@mercuree
Copy link
Contributor

It is not the MSCZ filename itself, but the filenames inside the MSCZ

Yes. But the magic is that if you rename the mscz file, it starts to open. You don't need to touch files inside archive at all.

@Jojo-Schmitz
Copy link
Contributor Author

I can't confirm that

@mercuree
Copy link
Contributor

file_rename_dot_issue.mp4

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 17, 2023

OK, confirmed, very strange

Just create new musescore file and save with file name started with dots. Then rename file to anything else and it becomes corrupted.

I can confirm this too!

@cbjeukendrup
Copy link
Contributor

Thanks a lot for the hints here! I think I'll have a solution ready soon.

@DmitryArefiev
Copy link
Contributor

Fixed in #20521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression MS3 Regression from MS3 (3.6.2)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants