some more plugin doc updates #11
Conversation
|
Not sure what git/GitHub is doing to me here, my intention was a pull request on Jojo-Schmitz@f55ad0b only |
| @@ -22,7 +22,7 @@ | |||
| class Spanner; | |||
|
|
|||
| //--------------------------------------------------------- | |||
| // DurationElement | |||
| // @@ DurationElement | |||
There was a problem hiding this comment.
Why did you add an annotation here? DurationElement doesn't seem to be exposed to the plugins
There was a problem hiding this comment.
These are referred to by other plugin docs, and lead to hyperlinks pointing to not existing docs.
Those @@ should lead to these pages to exists, even if basically empty.
E.g. chordrest.html links to durationelement.html ( "inherits DurationElement"), but that doesn't exist.
Bye, Jojo
-----Original Message-----
From: Nicolas Froment [mailto:reply+p-1164094-
65b81b42ae26c31b8819f1ae5f17aa18bad61062-1786669@reply.github.com]
Sent: Saturday, July 14, 2012 5:34 PM
To: Joachim Schmitz
Subject: Re: [MuseScore] some more plugin doc updates (#11)@@ -22,7 +22,7 @@
class Spanner;//---------------------------------------------------------
-// DurationElement
+// @@ DurationElementWhy did you add an annotation here? DurationElement doesn't seem to be
exposed to the plugins
Reply to this email directly or view it on GitHub:
https://github.com/musescore/MuseScore/pull/11/files#r1164094
|
I manually applied the changes on libmscore/harmony.h I don't understand the other ones since the classes are not part of the plugin interface. |
|
Only classes which are actually visible by the script interpreter should be documented (they have to be registered in mscore/plugins.cpp with qmlRegisterType). |
|
fine by me |
parent 4634008 author Igor Korsukov <i.korsukov@wsmgroup.ru> 1583311649 +0200 committer Igor Korsukov <igor.korsukov@gmail.com> 1584013991 +0300 # This is a combination of 5 commits. # This is the 1st commit message: audiveris import 12032020 # This is the commit message #2: Rename Choral templates for better sorting +collect_artifacts # This is the commit message #3: Make the remaining templates to fit one page for a better thumbnail # This is the commit message #4: follow up fix for Barbershop-Women template, musescore#5770 # This is the commit message #5: Score comparison tool: avoid crash on inability to merge text diffs Calling merge() on non-adjacent text diffs should probably not happen and reveals a potential bug in score diff code, but it is not a fatal error and should not lead to MuseScore crash. This commit avoids terminating MuseScore in this case. Score comparison still produces sensible results in case of such error. # This is the commit message #6: Avoid iterating over all spanners when saving ChordRest's slurs # This is the commit message #7: fix #289643: fix crashes if volta anchor is set incorrectly in MSCZ file # This is the commit message #8: fix #284988: Remove "Restart MuseScore" option from crash reporter This option doesn't work reliably so better remove it. # This is the commit message #9: Fix MacOS notarization errors # This is the commit message #10: Fix #302171: Preferences | Shortcuts should also search by keyboard shortcut Enhanced the Search box on the Shortcuts tab of the Preferences dialog to support searching for currently defined keyboard shortcuts in addition to action descriptions. # This is the commit message #11: Fix #302118: Need 24 and 32 bit WAV and FLAC audio exports and while at it, signed 8 bit too (unsigned 8 bit won't work for FLAC) # This is the commit message #12: code formatting +collect_artifacts # This is the commit message #13: Run vtests on PRs and commits to master branch and compare to parent commit vtest results; output a comment and upload a report when differences are found # This is the commit message #14: fix #300693: fb continuation not drawn when ending in voice 2 Resolves: https://musescore.org/en/node/300693 Continuation lines are drawn to the right edge of the last note that starts before the end of the figure's duration. The code that finds this note was only looking in voice 1. That resulted in continuation lines ending short, or disappearing, if the last note was in another voice. Fix is to be sure to check all voices when searchiing for the end CR. # This is the commit message #15: fix #290034: play repeats button not respected in new score # This is the commit message #16: fix #301753: figured bass under rests Altered condition within libmscore/figuredbass.cpp to allow for figures to be written under rests # This is the commit message #17: fix #301656: add "Baritone Horn (Central Europe)" basically sound similar to Baritone Horn and range similar to Euphonium
No description provided.