Prevent merging articulations on xml import #20248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 29, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 29, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 29, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 29, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 29, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 29, 2023
Backport of musescore#20248 Plus a part from musescore#19132
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 29, 2023
oktophonie
approved these changes
Nov 30, 2023
src/importexport/musicxml/tests/data/testArticulationCombination.xml
Outdated
Show resolved
Hide resolved
miiizen
force-pushed
the
xml-split-articulation
branch
from
1aa3977
to
e937396
Compare
cbjeukendrup
approved these changes
Nov 30, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 2, 2023
Backport of musescore#20248 Plus a bit from musescore#19132, those changes to exportxml.cpp (the rest is to follow later
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 2, 2023
Backport of musescore#20248 Plus a bit from musescore#19132, those changes to exportxml.cpp (the rest is to follow later
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 2, 2023
Backport of musescore#20248 Plus a bit from musescore#19132, those changes to exportxml.cpp (the rest is to follow later
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #19186
The crash in the issue arose from the code to create combined articulations from individual ones. We have since comitted to single articulations, so this code has been removed. I've also split up
<detached-legato>on import.