Fix GH#19186: Prevent merging articulations on xml import #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
3.x-xml-split-articulation
branch
6 times, most recently
from
49108f9
to
88ec312
Compare
|
Seems it needs (a part of) #159 first Edit: both done |
Jojo-Schmitz
force-pushed
the
3.x-xml-split-articulation
branch
from
88ec312
to
ce6490f
Compare
Jojo-Schmitz
force-pushed
the
3.x-xml-split-articulation
branch
from
9370e38
to
fb52366
Compare
Backport of musescore#20248 Plus a bit from musescore#19132, those changes to exportxml.cpp (the rest is to follow later
Jojo-Schmitz
force-pushed
the
3.x-xml-split-articulation
branch
from
1540c09
to
1f42494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of musescore#20248
Resolves: musescore#19186
The crash in the issue arose from the code to create combined articulations from individual ones. We have since comitted to single articulations, so this code has been removed. Also split up on import.