420_porting_fixes #20298
Merged
420_porting_fixes #20298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading elements, they actively call triggerLayout() (usually from setProperty). But because the elements don't have the correct parent tree at the time of reading, they can't provide the correct layout range for triggerLayout(). Since PlaybackModel also depends on this range, we can't correctly render playback events from it. So reset the range when the elements are read
This way we will know exactly what needs to be updated in PlaybackModel
Basically reverts a particular change from c35963f, but in a slightly different way, to make clearer why the old way was correct.
…on non-first staff of full score The `setTrack` calls were crucial to fix the crash; I've added the rest "just to be sure" and "for consistency".
Otherwise, myscore.mscz would be interpreted as `https://myscore.mscz/`.
Resolves: musescore#20203 In the score in this issue, there is an Arpeggio with a staff span of 2, which in 4.2 gets converted to a track span of 5. That's fine, but on the staff below the Arpeggio, there is a Rest, so the Arpeggio would end on that Rest. That leads to a crash because of a missing `isChord` check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20160
#20243
#20212
#20216
#20229
#20064
#20156
#20277
#20254
#20232
#20248
#20184
#20178
#20193
#20204
#20217
#20215
#20240
#20275