Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

421_port_fixes #20912

Merged
merged 12 commits into from
Jan 9, 2024
Merged

421_port_fixes #20912

merged 12 commits into from
Jan 9, 2024

Conversation

RomanPudashkin
Copy link
Contributor

@RomanPudashkin RomanPudashkin commented Jan 9, 2024

@cbjeukendrup
Copy link
Contributor

Not 100% sure if #19995 should be ported, because of #20411 which would be caused by that PR

sammik and others added 8 commits January 9, 2024 19:12
since we're not working with the position from AbstractEventSequencer
(AbstractEventSequencer::eventsToBePlayed isn't called, so we don't update it)
The current algorithm only supported english letters, all excerpts with non-english characters were marked _
packet, treat them individually according to MIDI 2.0 spec
@RomanPudashkin
Copy link
Contributor Author

Not 100% sure if #19995 should be ported, because of #20411 which would be caused by that PR

Agree. Not sure why it's in the project. Dropped it

@RomanPudashkin RomanPudashkin merged commit e416ab8 into musescore:4.2.1 Jan 9, 2024
11 checks passed
@RomanPudashkin RomanPudashkin deleted the 421_port_fixes branch January 10, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants