-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Musical symbols scale' option #20934
Merged
cbjeukendrup
merged 1 commit into
musescore:master
from
XiaoMigros:musical-symbols-scale
Feb 9, 2024
Merged
'Musical symbols scale' option #20934
cbjeukendrup
merged 1 commit into
musescore:master
from
XiaoMigros:musical-symbols-scale
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e86ebd
to
fc911cb
Compare
fc911cb
to
2eceb22
Compare
Saving
instead of
doesn't seem to be a good idea. |
The utests agree with you! A more elegant solution is underway... |
c5e793a
to
f83b86e
Compare
a35a16d
to
84bf2a6
Compare
oktophonie
approved these changes
Feb 7, 2024
mike-spa
approved these changes
Feb 7, 2024
bkunda
approved these changes
Feb 7, 2024
cbjeukendrup
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny almost-optional comments but for the rest this looks good to me!
84bf2a6
to
b74cd21
Compare
b74cd21
to
3f0785e
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #20772
Resolves: #19366
Resolves: #17885
This PR changes the following: