Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Musical Symbols Scale' for markers #21758

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

XiaoMigros
Copy link
Contributor

Resolves: #21757

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@XiaoMigros
Copy link
Contributor Author

I wonder if it's possible to check for Sid::dummyMusicalSymbolsScale being used, rather than to use a chain of ORs...

@XiaoMigros XiaoMigros force-pushed the markers-symbols-scale branch 3 times, most recently from dec4c50 to 8f872ed Compare March 1, 2024 08:40
@oktophonie oktophonie requested a review from mike-spa March 1, 2024 09:31
@cbjeukendrup
Copy link
Contributor

In the VTests, it looks like this has an undesired effect for existing scores (it makes those symbols much larger). Maybe some compat code is necessary to reset things in pre-4.4 scores?

@XiaoMigros
Copy link
Contributor Author

XiaoMigros commented Mar 25, 2024

In #20934 there were similar consequences (notably for pedal markings), but last time discussing with @oktophonie the conclusion was made that the symbols should now default to their 'true' size, regardless of context.

@cbjeukendrup
Copy link
Contributor

I tested it and found that the look of existing scores is indeed affected, but in such way that these scores look the same as when you'd create a new score in this PR's build. So that does make sense to me :)

@cbjeukendrup cbjeukendrup merged commit dbbfd84 into musescore:master Mar 28, 2024
10 of 11 checks passed
@XiaoMigros XiaoMigros deleted the markers-symbols-scale branch April 5, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement 'music symbol scale' for segnos and coda markers
4 participants