Fix note name translations in status bar

[bluebear94]

The note name translations belong to the EditPitchBase context, not the engraving context. Fix the context argument to muse::mtrc call accordingly.

Resolves: (Discord message)

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable) – is this applicable?

[Jojo-Schmitz]

Should make it into 4.3.0 too

[JLWALTENER]

@bluebear94 ,
Artefact tested

The Note name is fixed, that nice,
Unfortunately the Octave number is not translated, for reference the Octave number follow this

The Octave number is translated in French in the same file you have updated they are in the Octave 9 to -1

Thanks for your effort

[Jojo-Schmitz]

That's not a new issue though, been that way ever since, as far as I can tell

[JLWALTENER]

@Jojo-Schmitz ,
Exactely, I remember discussion on this since 0.9.3 with Nicolas...
It would be nice to be solved.

[Jojo-Schmitz]

Yes, it would. See also #19154

[JLWALTENER]

@Jojo-Schmitz ,
Excellent, I have not find this issue, as the Strings label is not positionned.
So your issue and mine is strictely the same, regarding language.

[cbjeukendrup]

This is not a good solution, for two reasons:

• The engraving module should not depend on things from other modules, and especially not on random UI classes. And thus also not on translation contexts that belong to other modules.
• (Passing "computed" things to the translation functions is perhaps not the safest idea, unless it's really certain that the computation will always produce something for which we have a suitable translatable string.) Putting this between parentheses because apparently it was already like this.

The better solution would be to move these strings to the engraving module and make the translation context engraving/notenames, and then reuse these strings in EditPitchBase, instead of basically the other way around. The notation module is allowed to depend on the engraving module.

(If you wonder, why would we do so difficult about this: in general, the purpose of "architecture" is making it easier to introduce features and making it less easy to introduce bugs. Small things like this contribute to that.)

[bluebear94]

Now that I’m looking at the translation files again, it turns out that I should have used the global context. This is probably more appropriate to use than the EditPitchBase context, though we might want to move these strings to an engraving/notenames context as @cbjeukendrup mentioned. Currently, these strings are used only in notenames.qml and AmbitusSettings.qml.

[cbjeukendrup]

I'm happy with this version for now!

[cbjeukendrup]

Resolves: (Discord message)

Dropping a screenshot of that message here for quick access:

(Note that for this PR the expected behaviour is "La4" for French, instead of "La3"; see above: #22427 (comment))

[JLWALTENER]

@cbjeukendrup ,
This is the reverse, the correct numbering is La3 for French instead of A4 for English.

[JLWALTENER]

Tested the new artefact, the result is the same as the first one.
So there is 2 bugs

1. Note names in the status bar was not translated, Fixed by this PR
2. Octave numbering in the status bar not translated, bug still exist

The correct translation of octave number could be found in Transifex, see the screenshot below

Could it be possible to retrieve the translated numbers from those strings ?

[Jojo-Schmitz]

That is a different issue, see further up and can't get solved with this PR but requires some code logic change.

[JLWALTENER]

@Jojo-Schmitz , Understood, but these 2 bugs are related, we cannot hve in the status bar le note name translated and the octave numbering not translated, otherwise we will have the same situation as MS v2 and 3.
I see no inconvenient to have 2 PRs, one to fix the note name translation, this one, and a second to fix the octave numbering, but merged at the same time.

[Jojo-Schmitz]

This PR and issue is about a recent regression (4.2.1 vs 4.3.0), the other is about an improvement, or maybe a bug, but a rather old one, existing sine Mu2. Yes. that should get fixed, eventually (and yes, rather sooner than later), but it hasn't got anything to do with the PR/issue at hand here.

[JLWALTENER]

For reference, the discussion in the French forum
https://musescore.org/fr/node/362519

[bluebear94]

If we want to localize octave indications, then we’ll need a translation for each pitch class in each octave. This is what we’re doing with the EditPitchBase translations, except that that doesn’t cover double-sharp and double-flat notes or enharmonic equivalents.

Eventually, we might want to unify note name translations in the EditPitchBase context with a future engraving/notenames context.

[JLWALTENER]

@bluebear94 ,
The double sharp and flat are correctely displayed in the status bar.
Curiously, the strings tuning are correctely translated, see below

[Jojo-Schmitz]

They come from an entirely different place. In the status bar they are constructed by concatenating a (translatable) notename and a calculated (and untranslatable) octave number

[JLWALTENER]

It's that I have understand.
It Is necessary I open a Feature request for this long standing need ?

[Jojo-Schmitz]

I believe #19154 covers that, doesn't it?

[JLWALTENER]

Ok, that's fine to me.

[zacjansheski]

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved

[Jojo-Schmitz]

This one needs to go to 4.3.0 too

[Jojo-Schmitz]

See #22481