Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #271636: Translate notenames in piano role editor and status bar #6462

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Aug 17, 2020

Resolves
https://musescore.org/en/node/271636

including the piano tool keyboard tooltips, also for piano roll editor, there including the strings for drumsets too.

mscore/pianotools.cpp Outdated Show resolved Hide resolved
@anatoly-os
Copy link
Contributor

Changing translatable strings is up to 3.6

@anatoly-os anatoly-os added this to the MuseScore 3.6 milestone Aug 25, 2020
@Jojo-Schmitz
Copy link
Contributor Author

@anatoly-os : please recheck/reconsider: There's no new or changed translatable strings, it just picks on existing translations!

@anatoly-os anatoly-os added the strings Affects translatable strings label Aug 26, 2020
@anatoly-os
Copy link
Contributor

anatoly-os commented Aug 26, 2020

@Jojo-Schmitz
I don't see InspectorAmbitus string on Transifex, but Inspector Ambitus.
I see neither utils nor drumset strings as well.

What do I miss?

@Jojo-Schmitz
Copy link
Contributor Author

These are not the strings, but their context. Causing the translation of the actual (and existing unchanged) string getting reused here.
Again: this PR does not add or change any existing string!

@Jojo-Schmitz Jojo-Schmitz changed the title translate notenames in piano role editor and status bar Fix #271636: Translate notenames in piano role editor and status bar Aug 29, 2020
including the piano tool keyboard tooltips, also for piano roll editor,
there including the strings for drumsets too.
@Jojo-Schmitz
Copy link
Contributor Author

Again: while this PR indeed does change some strings (namely PianoKeyboard::pitchNames[] and pitchNames[]), it does not change or add any translatable strings, it instead just picks up existing translations, so I see no reason to not include it in 3.5.1.

@anatoly-os anatoly-os merged commit a764a5c into musescore:3.x Sep 7, 2020
anatoly-os added a commit that referenced this pull request Sep 7, 2020
@Jojo-Schmitz Jojo-Schmitz deleted the notename-translations branch September 8, 2020 06:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
strings Affects translatable strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants